Merged
Conversation
Move definition of rp/k-dependent dataframes to top Add safety-check if dataframe exists
Adjust some descriptions
Reorder some functions and definitions alphabetically
Introduce version-check for parameters (with enforcement)
Fix warning messages in ExcelReader
Allow pathlib.Path for loading and writing CaseStudy
Implement scaling for import export price
Fix missing trailing / if using ExcelWriter from command line
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request merges the storage and rate of return (RoR) functionality by adding support for storage units and hydroelectric power inflows. The changes introduce comprehensive data structures for managing energy storage systems and renewable inflows.
Key changes:
- Added support for Power_Inflows_KInRows table format alongside existing Power_Inflows
- Updated column naming from IsLDS to IsLDES (Long-Duration Energy Storage)
- Enhanced error handling to use warnings instead of exceptions for missing inflow generators
Reviewed Changes
Copilot reviewed 6 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_ExcelReaderWriter.py | Added test entry for Power_Inflows_KInRows table and updated function references |
| Utilities.py | Enhanced inflow processing with warning-based error handling and data filtering |
| TableDefinitions.xml | Added Power_Inflows_KInRows definition, updated versions, and corrected storage terminology |
| ExcelWriter.py | Added write_caseStudy method and new Power_Inflows_KInRows writer function |
| ExcelReader.py | Added get_Power_Inflows_KInRows function and updated version specifiers |
| CaseStudy.py | Enhanced filtering methods with inplace options and improved data structure management |
Comments suppressed due to low confidence (1)
ExcelWriter.py:1
- Missing comma after the last tuple element. This will cause a syntax error when this code is executed.
import os
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.